Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT-1718: Add Note and Formatting event types #6691

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Jan 20, 2023

resolves #6481

Description

This PR replaces the EmptyLine event with a more general Formatting event. This new event isn't any semantically useful than EmptyLine, but let's us replace a broader set of events which are used only for formatting console output with a single event for that purpose which can be ignored for the purposes of structured logging.

This PR also adds a Note event, which is closer in spirit to the "FYI" event type mentioned in the original issue, and which dbt-server has asked us to include so that they can insert messages into the dbt log.

Checklist

@peterallenwebb peterallenwebb requested a review from a team January 20, 2023 22:20
@peterallenwebb peterallenwebb requested review from a team as code owners January 20, 2023 22:20
@cla-bot cla-bot bot added the cla:yes label Jan 20, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1718] Add an "FYI" Message Type
2 participants