Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --version in click #6802

Merged
merged 6 commits into from
Jan 31, 2023
Merged

Conversation

stu-k
Copy link
Contributor

@stu-k stu-k commented Jan 31, 2023

resolves #6757
duplicate of #6760, I messed up the commit history on that one

Checklist

@cla-bot cla-bot bot added the cla:yes label Jan 31, 2023
@stu-k stu-k closed this Jan 31, 2023
@stu-k stu-k reopened this Jan 31, 2023
@stu-k stu-k mentioned this pull request Jan 31, 2023
6 tasks
@stu-k stu-k marked this pull request as ready for review January 31, 2023 18:05
@stu-k stu-k requested review from leahwicz and a team as code owners January 31, 2023 18:05
core/dbt/cli/main.py Outdated Show resolved Hide resolved
@stu-k stu-k force-pushed the CT-1926/migrate-version-task-2 branch from 17aab22 to 0cff15a Compare January 31, 2023 18:24
@stu-k stu-k requested a review from MichelleArk January 31, 2023 18:25
@MichelleArk
Copy link
Contributor

Looks like we're getting to some real errors now in the code-quality CI check now!

From https://github.com/dbt-labs/dbt-core/actions/runs/4057145563/jobs/6982526380:

core/dbt/cli/main.py:2:1: F401 'pprint.pformat as pf' imported but unused

Looks like a quick one-liner fix so we could fix it here or punt it to a follow-up, your call!

@stu-k stu-k closed this Jan 31, 2023
@stu-k stu-k reopened this Jan 31, 2023
@stu-k stu-k merged commit 59d773e into feature/click-cli Jan 31, 2023
@stu-k stu-k deleted the CT-1926/migrate-version-task-2 branch January 31, 2023 18:40
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the try/catch?

core/dbt/cli/main.py Show resolved Hide resolved
@iknox-fa iknox-fa restored the CT-1926/migrate-version-task-2 branch January 31, 2023 20:48
@aranke aranke mentioned this pull request Feb 8, 2023
6 tasks
@stu-k stu-k deleted the CT-1926/migrate-version-task-2 branch February 20, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants