Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT] 1.4.latest update regex to match all iterations (#6839) #6846

Merged
merged 3 commits into from
Feb 6, 2023
Merged

[BACKPORT] 1.4.latest update regex to match all iterations (#6839) #6846

merged 3 commits into from
Feb 6, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 2, 2023

backport #6839

@emmyoop
update regex to match all iterations (#6839)
58e0b8f 
* update regex to match all iterations

* convert to num to match all adapters

* add comments, remove extra .

* clarify with more comments

* Update .bumpversion.cfg

Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>

---------

Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
# Conflicts:
#	.bumpversion.cfg
@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Feb 2, 2023
@emmyoop emmyoop requested a review from a team as a code owner February 2, 2023 18:21
@cla-bot cla-bot bot added the cla:yes label Feb 2, 2023
@emmyoop emmyoop requested review from leahwicz and removed request for ChenyuLInx and Mathyoub February 2, 2023 18:21
@emmyoop emmyoop changed the title update regex to match all iterations (#6839) [BACKPORT] update regex to match all iterations (#6839) Feb 2, 2023
@emmyoop emmyoop requested a review from jtcohen6 February 3, 2023 15:27
@emmyoop emmyoop changed the title [BACKPORT] update regex to match all iterations (#6839) [BACKPORT] 1.4.latest update regex to match all iterations (#6839) Feb 3, 2023
@emmyoop
Copy link
Member Author

emmyoop commented Feb 3, 2023

tested here: https://github.com/dbt-labs/dbt-core/actions/runs/4086321648/jobs/7045462714

@emmyoop emmyoop merged commit f6926c0 into 1.4.latest Feb 6, 2023
@emmyoop emmyoop deleted the backport/1.4.latest-fix-regex branch February 6, 2023 19:54
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahwicz leahwicz leahwicz approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmyoop @leahwicz