[CT-1959]: moving simple_seed tests to adapter zone #6859
Conversation
nssalian
added
Skip Changelog
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
|
|
||
| # manual copy because seed has a special and tricky-to-include unicode character at 0 |
There was a problem hiding this comment.
do we need to preserve these as actual .csv files to validate this? I'm wondering if it would be easier to have a core-only test that looks at some of these edge cases (BOM, unicode etc.) and an actually "simple" seed test in the adapter zone that just validates loading csv files
There was a problem hiding this comment.
I think that would be a better approach. I'll modify the code.
Update: rethinking this - the adapter zone could include a csv that checks for these cases rather than having the tests split across the two paths. No duplication.
There was a problem hiding this comment.
A good rework of this test. Now, I remember how hard this was when I did it because of the BOM unprintable character -- it stumped everyone on the team until I chanced upon the hidden character one day.
Can we comment referencing that on which test case that is, just so people understand we have a hidden character there? That feels very important for future readers who may run into unprintable character issues.
Otherwise, LGTM
* Formatting * Changelog entry * Rename to BaseSimpleSeedColumnOverride * Better error handling * Update test to include the BOM test * Cleanup and formating * Unused import remove * nit line * Pr comments (cherry picked from commit 4c63b63)
* Formatting * Changelog entry * Rename to BaseSimpleSeedColumnOverride * Better error handling * Update test to include the BOM test * Cleanup and formating * Unused import remove * nit line * Pr comments (cherry picked from commit 4c63b63) Co-authored-by: Neelesh Salian <nssalian@users.noreply.github.com>
resolves #
Description
Moving the simple seed test code over to the adapter zone to help convert tests in adapters.
Checklist
changie newto create a changelog entry