Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix snowflake seed types, add chunking for seed files with more than 16k rows #694

Merged
merged 8 commits into from
Apr 9, 2018

Conversation

cmcarthur
Copy link
Member

@cmcarthur cmcarthur commented Mar 13, 2018

This fixes two things:

  • It allows seed files over 16k rows on Snowflake
  • It uses floats for seed files instead of numeric / decimal types

@cmcarthur cmcarthur changed the title fix snowflake seed types, add chunking for >100k data sets fix snowflake seed types, add chunking for seed files with more than 16k rows Mar 13, 2018
@cmcarthur
Copy link
Member Author

Fix for #690

",\n".join(placeholders)))

cls.add_query(profile, sql,
bindings=bindings,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmcarthur is this correct? It seems to me that the second chunk would get the bindings from the first chunk?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bindings is reset inside the outer loop

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT @cmcarthur

let's get this working in development, then revisit the float8 decision :)

@drewbanin drewbanin added this to the Adapter Parity milestone Apr 4, 2018
@cmcarthur cmcarthur merged commit 848ff6a into development Apr 9, 2018
@cmcarthur cmcarthur deleted the fix/snowflake-seeds branch April 9, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants