Always write run_results.json
#7539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
iknox-fa
commented
May 6, 2023
core/dbt/task/runnable.py
Outdated
| self.previous_state: Optional[PreviousState] = None | ||
| self.run_count: int = 0 | ||
| self.started: float = 0 |
There was a problem hiding this comment.
self.started is the only new value here. The rest of the changes are just sorting things for readability.
iknox-fa
commented
May 9, 2023
iknox-fa
requested review from
stu-k,
peterallenwebb,
emmyoop and
VersusFacit
and removed request for
a team,
peterallenwebb,
emmyoop and
VersusFacit
aranke
reviewed
May 9, 2023
stu-k
reviewed
May 9, 2023
There was a problem hiding this comment.
Just a few comments. I don't have any better suggestions on the testing strategies though, apologies. It may be a good idea to get a review from someone on language as well since results/writing is technically their domain, I think. Feel free to re-request a review when my comments have been resolved!
This was referenced May 9, 2023
3 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7302
resolves #7448
Description
In an effort to ensure
run_results.jsonis always available regardless of whether or not the run was interrupted or terminated we now write them as each node finishes and once more at the end of the run.Checklist
changie newto create a changelog entry