Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target path should be relative to project dir, rather than current working directory #7706

Merged
merged 13 commits into from
May 26, 2023
Merged

Target path should be relative to project dir, rather than current working directory #7706

merged 13 commits into from
May 26, 2023

Commits on May 25, 2023

  1. Add "project_target_path" property to RuntimeConfig, switch to using it

    @gshank
    gshank committed May 25, 2023
    Configuration menu
    Copy the full SHA
    6f039a8 View commit details
    Browse the repository at this point in the history

  2. Split up write_node into "node_compiled_path" and "write_node" functions 

    so that we only store the relative path at node.compiled_path
    @gshank
    gshank committed May 25, 2023
    Configuration menu
    Copy the full SHA
    db8cd11 View commit details
    Browse the repository at this point in the history

  3. Adjust PreviousState object to use project_root to find "state" and 

    target directories
    @gshank
    gshank committed May 25, 2023
    Configuration menu
    Copy the full SHA
    340bb6e View commit details
    Browse the repository at this point in the history

  4. Update code to write out the "run" subdirectory of target

    @gshank
    gshank committed May 25, 2023
    Configuration menu
    Copy the full SHA
    bdc960a View commit details
    Browse the repository at this point in the history

  5. tweak project_target_path

    @gshank
    gshank committed May 25, 2023
    Configuration menu
    Copy the full SHA
    a22fb91 View commit details
    Browse the repository at this point in the history

  6. Changie

    @gshank
    gshank committed May 25, 2023
    Configuration menu
    Copy the full SHA
    8a9b67b View commit details
    Browse the repository at this point in the history

  7. fix test_graph_selector_methods.py test

    @gshank
    gshank committed May 25, 2023
    Configuration menu
    Copy the full SHA
    7875bb8 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Remove chdir that's no longer needed from test

    @gshank
    gshank committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a5719ed View commit details
    Browse the repository at this point in the history

  2. Modify target-path test to run from non-project directory

    @gshank
    gshank committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e92f3ce View commit details
    Browse the repository at this point in the history

  3. Remove resolve_path from state click.Path, modify defer_state test to 

    test
    @gshank
    gshank committed May 26, 2023
    Configuration menu
    Copy the full SHA
    05d298b View commit details
    Browse the repository at this point in the history

  4. use project_root when finding sources.json

    @gshank
    gshank committed May 26, 2023
    Configuration menu
    Copy the full SHA
    366a990 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ct-2491_target_paths

    @gshank
    gshank committed May 26, 2023
    Configuration menu
    Copy the full SHA
    58ea575 View commit details
    Browse the repository at this point in the history

  6. Update to account for defer_state changes

    @gshank
    gshank committed May 26, 2023
    Configuration menu
    Copy the full SHA
    51a2ebb View commit details
    Browse the repository at this point in the history