Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing f-strings in python models #7740

Closed
wants to merge 1 commit into from

Conversation

mederka
Copy link
Contributor

@mederka mederka commented May 31, 2023

resolves #6976

Description

Enables dbt command processing inside f-strings inside Python models.

Checklist

@mederka mederka requested a review from a team as a code owner May 31, 2023 08:44
@mederka mederka requested a review from ChenyuLInx May 31, 2023 08:44
@cla-bot cla-bot bot added the cla:yes label May 31, 2023
@mederka
Copy link
Contributor Author

mederka commented May 31, 2023

Hey there! I could not find a good place to include tests for this PR. Pointers highly appreciated.

@ChenyuLInx
Copy link
Contributor

@mederka thanks for adding the change! For adding unittest you can write one similar to this!

@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jun 25, 2023
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Dec 23, 2023
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering stale Issues that have gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2122] [Bug] project variables are None if dbt.config.get is called within string interpolation
3 participants