-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow enabling DEBUG logs for databricks-sql-connector #7860
Allow enabling DEBUG logs for databricks-sql-connector #7860
Conversation
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@susodapop We should be good to merge this, just checking if you have signed the CLA? |
@aranke would either you or @peterallenwebb (or both!) be willing to take a peek at @JerCo's comment here? His key question is:
|
Yes @aranke I've signed the CLA :) @dbeatty10 I responded to JerCo's comment in that thread. If this makes more sense in dbt-databricks we can move it there. The existing solution is meant to follow the pattern set for the snowflake connector. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@aranke CLA check is passing now. I'll let you either merge this (or not) depending on the outcome of this discussion: #7859 (comment) |
This won't actually work since it only enables the legacy logger that's being deprecated, see #8643 for inclusion in standard dbt logging |
I'm going to close this in favor of #8643 (which has been merged). We can re-visit this (including re-opening this PR) if needed. |
resolves #7859
Description
This change allows us to turn on
DEBUG
level logs fordatabricks-sql-connector
when invoked from dbt.Regarding documentation updates: I'm going to open a PR for dbt-databricks that includes more fine-grained control over the logs from databricks-sql-connector. The doc update for this PR will be included at that time.
Checklist
changie new
to create a changelog entry