Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport 7862 to 1.5.latest #7878

Merged
merged 2 commits into from
Jun 16, 2023
Merged

backport 7862 to 1.5.latest #7878

merged 2 commits into from
Jun 16, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Jun 14, 2023 •
edited
Loading

Description

Checklist

@colin-rogers-dbt colin-rogers-dbt requested review from a team as code owners June 14, 2023 22:21
@colin-rogers-dbt colin-rogers-dbt requested review from McKnight-42, emmyoop and VersusFacit and removed request for a team June 14, 2023 22:21
@cla-bot cla-bot bot added the cla:yes label Jun 14, 2023
@colin-rogers-dbt colin-rogers-dbt changed the base branch from main to 1.5.latest June 14, 2023 22:22
@colin-rogers-dbt
Copy link
Contributor Author

@jtcohen6 looks like I'd need to backport this change as well: https://github.com/dbt-labs/dbt-core/pull/7388/files

Otherwise we'll get:
E AttributeError: module 'dbt.events.types_pb2' has no attribute 'GenericTestFileParse'
The downside of the protobuf generation process 😢

@colin-rogers-dbt
Copy link
Contributor Author

Requires #7887

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 16, 2023 •
edited
Loading

I regenerated the event proto types on this branch (running make proto_types), and the failing unit test was passing locally. If that's the case, I don't think we need #7887.

@jtcohen6 jtcohen6 merged commit 9776e7a into 1.5.latest Jun 16, 2023
@jtcohen6 jtcohen6 deleted the backport-7862-to-1.5.latest branch June 16, 2023 15:23
@dbeatty10 dbeatty10 mentioned this pull request Jul 18, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@emmyoop emmyoop Awaiting requested review from emmyoop emmyoop was automatically assigned from dbt-labs/guild-oss-tooling

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit was automatically assigned from dbt-labs/guild-oss-tooling

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2435] [Feature] Display model versions with dbt show
3 participants
@colin-rogers-dbt @jtcohen6 @McKnight-42