Do not use sqlparse to construct ephemeral ctes #7919
Closed
+245
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranke
reviewed
Jun 22, 2023
core/dbt/compilation.py
Outdated
| with_stmt = word | ||
| break | ||
|
|
||
| joined_ctes = ", ".join(c.sql for c in ctes) |
There was a problem hiding this comment.
Should we break these out across multiple lines?
core/dbt/compilation.py
Outdated
| words_found = re.findall(r"\w+|[^\w\s]", sql, re.UNICODE) | ||
|
|
||
| with_stmt = None | ||
| for word in words_found: |
There was a problem hiding this comment.
Can we remove this loop by checking with in the regex itself?
| return string | ||
|
|
||
|
|
||
| def test_inject_ctes_0(): |
There was a problem hiding this comment.
Nit: Can we give the test functions more descriptive names than 1, 2, etc.?
3 tasks
3 tasks
|
Creating a different pull request since we pivoted to supporting sqlparse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7791
Description
Since we have been having issues with sqlparse as a dependency and only used it minimally in one place, replace that usage by constructing ephemeral ctes in another way.
Checklist
changie newto create a changelog entry