Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/materialized views/adap 608 #7985

Closed
wants to merge 30 commits into from
Closed

Feature/materialized views/adap 608 #7985

wants to merge 30 commits into from

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jun 29, 2023 •
edited
Loading

resolves #6911

Description

Pull more of the materialized views functionality out of the dbt-postgres space and into the dbt-core space.

Checklist

@cla-bot cla-bot bot added the cla:yes label Jun 29, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare marked this pull request as ready for review June 29, 2023 07:34
@mikealfare mikealfare requested review from a team as code owners June 29, 2023 07:34
@mikealfare mikealfare self-assigned this Jun 29, 2023
@mikealfare mikealfare mentioned this pull request Jul 11, 2023
Closed
4 tasks
dataders
dataders reviewed Jul 12, 2023
View reviewed changes
core/dbt/include/index.html Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I must have caught that with a find/replace. I'll make sure there are no changes from main, but I can't delete it as it's in main. Nice catch though.

@mikealfare
Copy link
Contributor Author

This PR is way out of date. The branch will be saved for reference, but the PR is stale.

@mikealfare mikealfare closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataders dataders dataders left review comments

@MichelleArk MichelleArk MichelleArk left review comments

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt left review comments

@VersusFacit VersusFacit Awaiting requested review from VersusFacit VersusFacit was automatically assigned from dbt-labs/adapters

@aranke aranke Awaiting requested review from aranke aranke is a code owner automatically assigned from dbt-labs/core-team

Assignees

@mikealfare mikealfare

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2068] [Feature] Let's add Materialized View as a materialization, finally
4 participants
@mikealfare @dataders @MichelleArk @colin-rogers-dbt