Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix query comment tests" #8093

Closed
wants to merge 1 commit into from
Closed

Revert "Fix query comment tests" #8093

wants to merge 1 commit into from

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jul 13, 2023 •
edited
Loading

Reverts #7928

Reason:

  • This PR was not tested against the adapters (shame on me), and this test failed in dbt-redshift:
image

@cla-bot cla-bot bot added the cla:yes label Jul 13, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label Jul 13, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review July 13, 2023 21:58
@dbeatty10 dbeatty10 requested review from a team as code owners July 13, 2023 21:58
@dbeatty10 dbeatty10 requested review from Fleid and QMalcolm July 13, 2023 21:58
QMalcolm
QMalcolm approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for shame, these things happen. Two way doors and all that jazz 🙂 Looks good to me!

@dbeatty10
Copy link
Contributor Author

Summary

✅ Turns out we do not need to revert this merge in dbt-core, because we were able to fix dbt-redshift instead.

Details

The observed failure in dbt-redshift was actually a good thing!

It only caused a failure in dbt-redshift because it caught a bug that we wanted it to catch. As a follow-up, @anders opened (and merged) a PR to fix it. 😎

We established that #8093 didn't break any other dbt Labs maintained adapters (in any novel ways) via these draft PRs:

Since test_query_comment didn't yield any novel CI failures, we are considering this revert unnecessary after all.

@dbeatty10 dbeatty10 closed this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QMalcolm QMalcolm QMalcolm approved these changes

@Fleid Fleid Awaiting requested review from Fleid Fleid was automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @QMalcolm