[CT-2594] Backport #8180 to 1.5.latest #8198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of approved and merged #8180 to 1.5.latest. In
1.5thewarn_error_optionsbegan being serialized as just a str representation of the pythonWarnErrorOptionsobject. However, this is not easily deserializable. in #8180 we started converting theWarnErrorOptionsduring serialization. See CT-2594 for more details.This backport was done by cherry-picking from the #8180 PR branch. Specifically
git cherry-pick 49e7a791b3b0d35db371043845209798886d5266^..99e484d1d28746be1251e14e5d950b6da641ea0b. No merge conflicts occurred, so no conflict resolutions were necessary.Checklist