Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect changes to model access, deprecation_date, and latest_version in state:modified #8264

Merged
merged 7 commits into from
Aug 10, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jul 31, 2023

resolves #8189
docs dbt-labs/docs.getdbt.com/# dbt-labs/docs.getdbt.com#3897

Problem

Solution

state:modified picks up changes to a model's ref representation:

  • modifying access
  • modifying deprecation_date
  • modifying latest_version

Any of these may cause downstream ref calls to change: potential errors from changing access, a different resolution of unpinned refs when latest_version changes, or additional warnings from deprecation_date.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Jul 31, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #8264 (8e171b8) into main (f230e41) will increase coverage by 0.01%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8264      +/-   ##
==========================================
+ Coverage   86.22%   86.24%   +0.01%     
==========================================
  Files         174      174              
  Lines       25515    25522       +7     
==========================================
+ Hits        22001    22011      +10     
+ Misses       3514     3511       -3     
Files Changed Coverage Δ
core/dbt/contracts/graph/nodes.py 94.49% <100.00%> (+0.02%) ⬆️
core/dbt/node_types.py 98.03% <100.00%> (ø)

... and 11 files with indirect coverage changes

@MichelleArk MichelleArk changed the title ModelNode.same_ref_representation Detect changes to model access, deprecation_date, and latest_version in state:modified Aug 9, 2023
@MichelleArk MichelleArk marked this pull request as ready for review August 9, 2023 14:02
@MichelleArk MichelleArk requested a review from a team as a code owner August 9, 2023 14:02
@MichelleArk MichelleArk requested a review from gshank August 9, 2023 14:02
@MichelleArk MichelleArk merged commit 6603a44 into main Aug 10, 2023
@MichelleArk MichelleArk deleted the 8189/modified-model-attributes branch August 10, 2023 15:29
github-actions bot pushed a commit that referenced this pull request Aug 10, 2023
MichelleArk added a commit that referenced this pull request Aug 11, 2023
…in state:modified (#8264) (#8354)

(cherry picked from commit 6603a44)

Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants