Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track plugin.get_nodes #8336

Merged
merged 2 commits into from
Aug 10, 2023
Merged

track plugin.get_nodes #8336

merged 2 commits into from
Aug 10, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Aug 7, 2023

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk force-pushed the plugin-get-nodes-tracking branch from 2c34de3 to fdc7880 Compare August 7, 2023 22:35
@MichelleArk MichelleArk changed the title test tracking track plugin.get_nodes Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #8336 (34abde3) into main (556b404) will increase coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #8336      +/-   ##
==========================================
+ Coverage   86.23%   86.28%   +0.05%     
==========================================
  Files         174      174              
  Lines       25518    25525       +7     
==========================================
+ Hits        22005    22025      +20     
+ Misses       3513     3500      -13     
Files Changed Coverage Δ
core/dbt/tracking.py 83.26% <40.00%> (+0.35%) ⬆️
core/dbt/plugins/manager.py 88.15% <100.00%> (+0.32%) ⬆️

... and 3 files with indirect coverage changes

@MichelleArk MichelleArk force-pushed the plugin-get-nodes-tracking branch from 03a21c7 to 34abde3 Compare August 9, 2023 13:49
@MichelleArk MichelleArk marked this pull request as ready for review August 9, 2023 13:50
@MichelleArk MichelleArk requested a review from a team as a code owner August 9, 2023 13:50
@MichelleArk MichelleArk requested a review from QMalcolm August 9, 2023 13:50
@MichelleArk MichelleArk merged commit 83ff38a into main Aug 10, 2023
@MichelleArk MichelleArk deleted the plugin-get-nodes-tracking branch August 10, 2023 15:33
@github-actions
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-8336-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83ff38ab24a820d0bfca411ac51b67eeb2ef878d
# Push it to GitHub
git push --set-upstream origin backport-8336-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-8336-to-1.6.latest.

MichelleArk added a commit that referenced this pull request Aug 11, 2023
(cherry picked from commit 83ff38a)
MichelleArk added a commit that referenced this pull request Aug 11, 2023
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants