Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8350: add connection status into list of statuses for dbt debug #8351

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Aug 10, 2023

resolves #8350
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Aug 10, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke
Copy link
Member Author

aranke commented Aug 10, 2023

🎩

dbt debug --target dummy
12:56:20  Running with dbt=1.7.0-a1
12:56:20  dbt version: 1.7.0-a1
12:56:20  python version: 3.10.8
12:56:20  python path: /Users/karanke/workspace/jaffle_shop_duckdb/venv/bin/python3
12:56:20  os info: macOS-14.0-arm64-arm-64bit
12:56:20  Using profiles dir at /Users/karanke/.dbt
12:56:20  Using profiles.yml file at /Users/karanke/.dbt/profiles.yml
12:56:20  Using dbt_project.yml file at /Users/karanke/workspace/jaffle_shop_duckdb/dbt_project.yml
12:56:20  adapter type: snowflake
12:56:20  adapter version: 1.7.0a1
12:56:20  Configuration:
12:56:20    profiles.yml file [OK found and valid]
12:56:20    dbt_project.yml file [OK found and valid]
12:56:20  Required dependencies:
12:56:21   - git [OK found]

12:56:21  Connection:
12:56:21    account: sk6
12:56:21    user: KSHITIJ.ARANKE@FISHTOWNANALYTICS.COM
12:56:21    database: dbt_test
12:56:21    warehouse: dbt_testing
12:56:21    role: tester
12:56:21    schema: dbt_karanke_clone
12:56:21    authenticator: externalbrowser
12:56:21    private_key: None
12:56:21    private_key_path: None
12:56:21    private_key_passphrase: None
12:56:21    token: None
12:56:21    oauth_client_id: None
12:56:21    query_tag: None
12:56:21    client_session_keep_alive: False
12:56:21    host: None
12:56:21    port: None
12:56:21    proxy_host: None
12:56:21    proxy_port: None
12:56:21    protocol: None
12:56:21    connect_retries: 1
12:56:21    connect_timeout: None
12:56:21    retry_on_database_errors: False
12:56:21    retry_all: False
12:56:21    insecure_mode: False
12:56:21    reuse_connections: None
12:56:21  Registered adapter: snowflake=1.7.0-a1
12:58:28    Connection test: [ERROR]

12:58:28  1 check failed:
12:58:28  dbt was unable to connect to the specified database.
The database returned the following error:

  >Database Error
  000403: HTTP 403: Forbidden

Check your database credentials and try again. For more information, visit:
https://docs.getdbt.com/docs/configure-your-profile



jaffle_shop_duckdb onduckdb [✘?] via 🐍 v3.10.8 (venv) took 2m9secho $status
1

@aranke aranke requested a review from gshank August 10, 2023 13:02
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #8351 (8aae62e) into main (8350dfe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8351   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files         174      174           
  Lines       25541    25541           
=======================================
  Hits        22046    22046           
  Misses       3495     3495           
Flag Coverage Δ
integration 83.09% <100.00%> (ø)
unit 65.18% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/task/debug.py 82.40% <100.00%> (ø)

@aranke aranke marked this pull request as ready for review August 10, 2023 17:49
@aranke aranke requested a review from a team as a code owner August 10, 2023 17:49
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for a fix that we want to backport, but I think we should have a test for it. Could you open a ticket to create a better test for the "debug" command?

@aranke aranke merged commit b514e4c into main Aug 14, 2023
@aranke aranke deleted the fix_8350 branch August 14, 2023 17:13
@benmosher
Copy link
Contributor

hey y'all -- I see the the back port 1.6.latest tag is on this PR, but it doesn't appear that it was ever actually backported?

@MitchellBarker
Copy link

^Any news on this? 😅 Just ran into this on 1.6.latest myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2956] [Regression] dbt debug returns success (0 exit code) when connection test fails
6 participants