Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return value to AdapterContainer.__init__ and AdapterMeta.__new__ #8523

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 30, 2023

resolves #8387

Problem

Mypy warnings because of lack of return value for functions.

Solution

Adds return values.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner August 30, 2023 18:04
@gshank gshank requested a review from mikealfare August 30, 2023 18:04
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank gshank requested a review from emmyoop August 30, 2023 18:05
@gshank gshank requested a review from a team as a code owner August 30, 2023 18:05
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (770f804) 86.35% compared to head (f615f6a) 86.31%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8523      +/-   ##
==========================================
- Coverage   86.35%   86.31%   -0.05%     
==========================================
  Files         174      174              
  Lines       25561    25579      +18     
==========================================
+ Hits        22074    22079       +5     
- Misses       3487     3500      +13     
Flag Coverage Δ
integration 83.09% <100.00%> (-0.11%) ⬇️
unit 65.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/adapters/base/meta.py 98.11% <100.00%> (ø)
core/dbt/adapters/factory.py 91.89% <100.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cla-bot cla-bot bot added the cla:yes label Aug 30, 2023
@gshank gshank merged commit 72898c7 into main Aug 30, 2023
54 of 55 checks passed
@gshank gshank deleted the 8397-adapters_factory_fn branch August 30, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2972] [Epic] MyPy Cleanup
2 participants