Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove label #8557

Merged
merged 1 commit into from
Sep 6, 2023
Merged

remove label #8557

merged 1 commit into from
Sep 6, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Sep 5, 2023

resolves #8439

Problem

The workflow doesn't use labels anymore

Solution

Remove label input

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Tied tightly to dbt-labs/actions#134

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Sep 5, 2023
@cla-bot cla-bot bot added the cla:yes label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (a0e1356) 86.37% compared to head (8e0daa1) 86.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8557      +/-   ##
==========================================
- Coverage   86.37%   86.36%   -0.01%     
==========================================
  Files         174      174              
  Lines       25587    25587              
==========================================
- Hits        22100    22099       -1     
- Misses       3487     3488       +1     
Flag Coverage Δ
integration 83.17% <ø> (-0.01%) ⬇️
unit 65.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review September 5, 2023 19:06
@emmyoop emmyoop requested a review from a team as a code owner September 5, 2023 19:06
@emmyoop emmyoop requested review from aranke and VersusFacit and removed request for a team September 5, 2023 19:06
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop merged commit 7e2a08f into main Sep 6, 2023
@emmyoop emmyoop deleted the er/fix-doc-issue-trigger branch September 6, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3006] [Bug] Generating docs.getdbt.com issues is missing data
2 participants