Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8398: Add typing to __init__ in base.py #8568

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix #8398: Add typing to __init__ in base.py #8568

merged 1 commit into from
Sep 6, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Sep 6, 2023

resolves #8398
docs dbt-labs/docs.getdbt.com/#

Problem

__init__ in base.py was untyped.

Solution

Add a return type of None to __init__ in base.py.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@aranke aranke requested a review from a team as a code owner September 6, 2023 15:49
@aranke aranke requested a review from gshank September 6, 2023 15:49
@cla-bot cla-bot bot added the cla:yes label Sep 6, 2023
@aranke aranke requested a review from emmyoop September 6, 2023 15:49
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (7e2a08f) 86.41% compared to head (b4dec9e) 86.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8568      +/-   ##
==========================================
- Coverage   86.41%   86.37%   -0.05%     
==========================================
  Files         174      174              
  Lines       25587    25587              
==========================================
- Hits        22112    22100      -12     
- Misses       3475     3487      +12     
Flag Coverage Δ
integration 83.17% <100.00%> (-0.12%) ⬇️
unit 65.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/task/base.py 76.01% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

Do you happen to know why mypy wants this typed? It doesn't always complain about __init__ being untyped.

@aranke
Copy link
Member Author

aranke commented Sep 6, 2023

Do you happen to know why mypy wants this typed?

No idea honestly.

@aranke aranke merged commit 9aff3ca into main Sep 6, 2023
54 of 55 checks passed
@aranke aranke deleted the fix_8398 branch September 6, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2982] Fix untyped functions in task/base.py (mypy warning)
2 participants