-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip and rename test_expression_metric #8578
Unskip and rename test_expression_metric #8578
Commits on Sep 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1ac2f04 - Browse repository at this point
Copy the full SHA 1ac2f04View commit details -
Configuration menu - View commit details
-
Copy full SHA for b84b575 - Browse repository at this point
Copy the full SHA b84b575View commit details -
Configuration menu - View commit details
-
Copy full SHA for a92e5aa - Browse repository at this point
Copy the full SHA a92e5aaView commit details -
Add typing to
base_metric_dependency
and `derived_metric_dependency……` and update functions to work on 1.6+ metrics
Configuration menu - View commit details
-
Copy full SHA for c8389f9 - Browse repository at this point
Copy the full SHA c8389f9View commit details -
Simplify implementations of
basic_metric_dependency
and `derived_me……tric_dependnecy`
Configuration menu - View commit details
-
Copy full SHA for 8f0c5c6 - Browse repository at this point
Copy the full SHA 8f0c5c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e062cb - Browse repository at this point
Copy the full SHA 4e062cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dfe539 - Browse repository at this point
Copy the full SHA 4dfe539View commit details -
Simplify conditional controls in
ResolvedMetricReference
functionsThe functions in `ResolvedMetricReference` use `manifest.metric.get(...)` which will only return either a `Metric` or `None`, never a different node type. Thus we don't need to check that the returned metric is a metric.
Configuration menu - View commit details
-
Copy full SHA for 4a11c9f - Browse repository at this point
Copy the full SHA 4a11c9fView commit details -
Don't recurse on over
depends_on
for non-derived metrics in `revers……e_dag_parsing` The function `reverse_dag_parsing` only cares about derived metrics, that is metrics that depend on other metrics. Metrics only depend on other metrics if they are one of the `DERIVED_METRICS` types. Thus doing a recursive call to `reverse_dag_parsing` for non `DERIVED_METRICS` types is unnecessary. Previously we were iterating over a metric's `depends_on` property regardless of whether the metric was a `DERIVED_METRICS` type. Now we only do this work if the metric is of a `DERIVED_METRICS` type.
Configuration menu - View commit details
-
Copy full SHA for 41c8ad0 - Browse repository at this point
Copy the full SHA 41c8ad0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b476f28 - Browse repository at this point
Copy the full SHA b476f28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84c5091 - Browse repository at this point
Copy the full SHA 84c5091View commit details -
Configuration menu - View commit details
-
Copy full SHA for b073cff - Browse repository at this point
Copy the full SHA b073cffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 711ca98 - Browse repository at this point
Copy the full SHA 711ca98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70091df - Browse repository at this point
Copy the full SHA 70091dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for da99e59 - Browse repository at this point
Copy the full SHA da99e59View commit details
Commits on Sep 7, 2023
-
Move from
manifest.metrics.get
tomanifest.expect
in metric helpersPreviously with `manifest.metrics.get` we were just skipping when `None` was returned. Getting `None` back was expected in that `parent_unique_id`s that didn't belong to metrics should return `None` when calling `manifest.metrics.get`, and these are fine to skip. However, there's an edgecase where a `parent_unique_id` is supposed to be a metric, but isn't found, thus returning `None`. How likely this edge case could get hit, I'm not sure, but it's a possible edge case. Using `manifest.metrics.get` it we can't actually tell if we're in the edge case or not. By moving to `manifest.expect` we get the error handling built in, and the only trade off is that we need to change our conditional to skip returned nodes that aren't metrics.
Configuration menu - View commit details
-
Copy full SHA for f80b4e1 - Browse repository at this point
Copy the full SHA f80b4e1View commit details