Rewrite relationships schema test for improved performance #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MartinLue
commented
Jul 23, 2018
MartinLue
commented
- Replace WHERE foo NOT IN subquery with LEFT JOIN
- Use SELECT DISTINCT to avoid double counting if relationships test is applied on fields with non-unique values
Replace WHERE foo NOT IN subquery with LEFT JOIN Use SELECT DISTINCT to avoid double counting if relationships test is applied on fields with non-unique values
|
@jthandy Tristan, we recently discussed the poor performance (at least on our Postgresql db) of the dbt relationship tests. Here is our take on how this should look like. |
MartinLue
changed the title
|
Oh this PR seems to duplicate #799. Nevermind. |
|
fixed in #921 , closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.