Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: avoid double-rendering sql_header in dbt show #8740

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix: avoid double-rendering sql_header in dbt show #8740

merged 2 commits into from
Sep 28, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 28, 2023 •
edited
Loading

resolves #8739

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@MichelleArk MichelleArk requested review from a team as code owners September 28, 2023 17:49
@cla-bot cla-bot bot added the cla:yes label Sep 28, 2023
MichelleArk
MichelleArk commented Sep 28, 2023
View reviewed changes
tests/adapter/dbt/tests/adapter/dbt_show/test_dbt_show.py
@@ -50,7 +50,6 @@ def models(self):
}

def test_sql_header(self, project):
run_dbt(["build", "--vars", "timezone: Asia/Kolkata"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not necessary

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0c965c8) 86.62% compared to head (795e2e1) 86.62%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8740   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files         176      176           
  Lines       25772    25772           
=======================================
  Hits        22325    22325           
  Misses       3447     3447
Flag Coverage Δ
integration 83.38% <ø> (ø)
unit 65.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk
Copy link
Contributor Author

Updated BQ test: dbt-labs/dbt-bigquery#927

@MichelleArk
Copy link
Contributor Author

Updated redshift test: dbt-labs/dbt-redshift#611

@MichelleArk
Copy link
Contributor Author

Updated snowflake test: dbt-labs/dbt-snowflake#779

@MichelleArk MichelleArk merged commit 408a789 into main Sep 28, 2023
65 checks passed
@MichelleArk MichelleArk deleted the improve-show-fixture branch September 28, 2023 18:35
This was referenced Sep 28, 2023
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@MichelleArk @github-actions
Fix: avoid double-rendering sql_header in dbt show (#8740)
08624c9 
(cherry picked from commit 408a789)
github-actions bot pushed a commit that referenced this pull request Sep 28, 2023
@MichelleArk @github-actions
Fix: avoid double-rendering sql_header in dbt show (#8740)
9d89fdf 
(cherry picked from commit 408a789)
McKnight-42 pushed a commit that referenced this pull request Sep 28, 2023
@github-actions @MichelleArk
Fix: avoid double-rendering sql_header in dbt show (#8740) (#8741)
5d49158 
(cherry picked from commit 408a789)

Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
McKnight-42 pushed a commit that referenced this pull request Sep 28, 2023
@github-actions @MichelleArk
Fix: avoid double-rendering sql_header in dbt show (#8740) (#8742)
6fb39bf 
(cherry picked from commit 408a789)

Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
QMalcolm pushed a commit that referenced this pull request Oct 9, 2023
@MichelleArk @QMalcolm
Fix: avoid double-rendering sql_header in dbt show (#8740)
88dacdf
@tlento tlento mentioned this pull request Nov 6, 2023
Merged
5 tasks
@tlento tlento mentioned this pull request Feb 26, 2024
Merged
@aranke aranke mentioned this pull request Jul 12, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@mikealfare mikealfare Awaiting requested review from mikealfare mikealfare was automatically assigned from dbt-labs/adapters

@emmyoop emmyoop Awaiting requested review from emmyoop emmyoop is a code owner automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
backport 1.5.latest backport 1.6.latest cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-3170] [Fix] sql_header is being rendered twice in dbt show
3 participants
@MichelleArk @McKnight-42 @colin-rogers-dbt