Cache plugin modules #9031
Merged
Cache plugin modules #9031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9031 +/- ##
==========================================
- Coverage 86.66% 86.61% -0.06%
==========================================
Files 179 179
Lines 26564 26569 +5
==========================================
- Hits 23022 23013 -9
- Misses 3542 3556 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Python 3.8 lacks |
jtcohen6
reviewed
Nov 9, 2023
core/dbt/plugins/manager.py
Outdated
| @@ -63,6 +65,17 @@ def get_manifest_artifacts(self, manifest: Manifest) -> PluginArtifacts: | |||
| raise NotImplementedError(f"get_manifest_artifacts hook not implemented for {self.name}") | |||
|
|
|||
|
|
|||
| @functools.cache | |||
There was a problem hiding this comment.
@peterallenwebb Per docs, sounds like @functools.cache might just be 3.9+ syntactic sugar for @functools.lru_cache(maxsize=None), which is available on earlier versions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9029
Local results:
Problem
Scanning all available python modules is slow.
Solution
For the purposes of detecting dbt plugins, only do this once per process invocation and cache the result.
Checklist