Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbt deps failing on tarballs #9068

Merged
merged 7 commits into from
Nov 14, 2023

Commits on Nov 13, 2023

  1. tarball lockfile fix

    ChenyuLInx committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    daaaa8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b17772a View commit details
    Browse the repository at this point in the history
  3. Add integration test for ensuring tarball package specification works

    This test was written _after_ the fix was commited. However, I ran this
    test against main without the fix and it failed. After running the test
    with the tarball fix, it passed.
    QMalcolm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7ca879c View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary tarball conditional logic in `PackageConfig.vali…

    …date`
    
    We had a conditional to skip validation for a package if the package
    included the `tarball` key. However, this conditional always returned
    false as it was nested inside a conditional that the package had the
    default `package` key, which means it's not a tarball package, but a
    package package (maybe we need better differentiation here). If we need
    additional validation for tarballs down the road, we should do that one
    level up. At this time we have no additional validaitons to add.
    QMalcolm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0bd7ecd View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Configuration menu
    Copy the full SHA
    d93c523 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6d68e78 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary setUp fixture from tarball package tests

    We initially included this fixture due to copy and pasting another
    test. However, this `setUp` fixture isn't actually necessary for the
    tarball dependency tests.
    QMalcolm committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    cb29a01 View commit details
    Browse the repository at this point in the history