Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.7.latest] Fix dbt deps failing on tarballs #9075

Merged
merged 2 commits into from
Nov 15, 2023

Commits on Nov 14, 2023

  1. Fix dbt deps failing on tarballs (#9068)

    * tarball lockfile fix
    
    * Add changie doc for tarball deps issue
    
    * Add integration test for ensuring tarball package specification works
    
    This test was written _after_ the fix was commited. However, I ran this
    test against main without the fix and it failed. After running the test
    with the tarball fix, it passed.
    
    * Remove unnecessary `tarball` conditional logic in `PackageConfig.validate`
    
    We had a conditional to skip validation for a package if the package
    included the `tarball` key. However, this conditional always returned
    false as it was nested inside a conditional that the package had the
    default `package` key, which means it's not a tarball package, but a
    package package (maybe we need better differentiation here). If we need
    additional validation for tarballs down the road, we should do that one
    level up. At this time we have no additional validaitons to add.
    
    * Fix typos in changie doc for tarball deps issue
    
    * Improve tarball package test naming and add related unhappy path test
    
    * Remove unnecessary `setUp` fixture from tarball package tests
    
    We initially included this fixture due to copy and pasting another
    test. However, this `setUp` fixture isn't actually necessary for the
    tarball dependency tests.
    
    ---------
    
    Co-authored-by: Chenyu Li <chenyu.li@dbtlabs.com>
    (cherry picked from commit 017faf4)
    QMalcolm authored and github-actions[bot] committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2fab832 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Configuration menu
    Copy the full SHA
    1f3c890 View commit details
    Browse the repository at this point in the history