Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro resolver remove lazy loading #9232

Conversation

MichelleArk
Copy link
Contributor

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Dec 6, 2023
@MichelleArk MichelleArk changed the base branch from feature/decouple-adapters-from-core to relation-create-from-refactor December 6, 2023 14:28
@MichelleArk
Copy link
Contributor Author

After this change:

x❯ python3 scripts/migrate-adapters.py core/dbt/adapters

core/dbt/adapters/protocol.py:
  - dbt.contracts.graph.model_config::BaseConfig
  - dbt.contracts.graph.manifest::Manifest

core/dbt/adapters/factory.py:
  - dbt.mp_context::get_mp_context

core/dbt/adapters/base/connections.py:
  - dbt.contracts.graph.manifest::Manifest

core/dbt/adapters/base/query_headers.py:
  - dbt.context.manifest::generate_query_header_context
  - dbt.contracts.graph.manifest::Manifest

core/dbt/adapters/base/impl.py:
  - dbt.contracts.graph.manifest::Manifest

migration progress: 97.07% of dbt imports are valid (from adapters or common)
remaining core imports: 7

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 529 lines in your changes are missing coverage. Please review.

Comparison is base (ed90356) 86.14% compared to head (60f8741) 86.56%.
Report is 59 commits behind head on feature/decouple-adapters-from-core.

Files Patch % Lines
core/dbt/adapters/events/adapter_types_pb2.py 6.70% 181 Missing ⚠️
core/dbt/adapters/exceptions/compilation.py 43.75% 81 Missing ⚠️
core/dbt/events/core_types_pb2.py 17.91% 55 Missing ⚠️
core/dbt/common/exceptions/macros.py 52.30% 31 Missing ⚠️
core/dbt/common/clients/jinja.py 89.73% 27 Missing ⚠️
core/dbt/common/exceptions/base.py 86.25% 22 Missing ⚠️
core/dbt/common/utils/encoding.py 52.77% 17 Missing ⚠️
core/dbt/common/exceptions/cache.py 65.85% 14 Missing ⚠️
core/dbt/common/utils/executor.py 65.00% 14 Missing ⚠️
core/dbt/adapters/base/connections.py 56.52% 10 Missing ⚠️
... and 27 more
Additional details and impacted files
@@                           Coverage Diff                           @@
##           feature/decouple-adapters-from-core    #9232      +/-   ##
=======================================================================
+ Coverage                                86.14%   86.56%   +0.42%     
=======================================================================
  Files                                      183      216      +33     
  Lines                                    26468    26868     +400     
=======================================================================
+ Hits                                     22800    23258     +458     
+ Misses                                    3668     3610      -58     
Flag Coverage Δ
integration 83.42% <73.81%> (+0.37%) ⬆️
unit 65.20% <69.92%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from relation-create-from-refactor to feature/decouple-adapters-from-core December 6, 2023 18:46
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk
Copy link
Contributor Author

Closing in favor of: #9243

@MichelleArk MichelleArk closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants