[Backport 1.7.latest] Update parser to support conversion metrics #9173 #9255
+701
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're backporting a feature "conversion metrics" to 1.7. Conversion metrics don't exist in DSI < 0.4.2 which is problematic if we allow for those versions. This ensures that those who are on a version of 1.7 that supports conversion metrics will also have the requisit version of DSI.
QMalcolm
requested review from
vadim82 and
MichelleArk
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.7.latest #9255 +/- ##
==============================================
+ Coverage 83.40% 86.61% +3.20%
==============================================
Files 179 179
Lines 26575 26612 +37
==============================================
+ Hits 22166 23050 +884
+ Misses 4409 3562 -847
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martynydbt
approved these changes
Dec 7, 2023
|
Holding off on merging until with the Cloud Artifacts team can make sure this will be okay on their end. |
|
Confirmed with the Cloud Artifacts Team that the new artifacts don't cause any issues 🎉 Moving forward with merging 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9203
This is a manual backport of #9173 to
1.7.latest.This is a manual backport because the automatic backport failed (merge conflicts), some commits needed to be excluded as they have no relevance to 1.7.latest, and some new commits needed to be added specifically for
1.7.latest.Included commits from #9173 via
cherry-pickExcluded commits
Newly added commits