Ensure support for external nodes in unit tests #9271
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8944
Problem
We weren't sure if external nodes in unit tests would just work, and it turns out that they do!
Note: this wasn't originally working
Before the winter break this didn't just work. I started on this work early in December, and at that time it was failing to find the external node at ref resolution time. This was because under the hood the identifier for refs in unit tests are under a different name to spoof the node to be ref'd. At the time there was a disconnect between the ref in the unit test, and the unit test in the model.
Solution
Added a test which includes an external node
Note
There is no changelog for this PR because nothing in core itself was changed, just an added test.
Checklist