Decouple warn error options from core and adapters #9338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9337
Problem
WarnErrorOptions is now defined in dbt/common, which is being moved to a separate upstream package/repo (dbt-common) shortly. It is defined in dbt/common because it is used both by dbt-common and dbt-core. Unfortunately, it depends on both dbt-core and dbt-adapter to import the event type module to validate items in its collection. This would represent a circular dependency once moved to a separate repo as dbt-common should be upstream to both dbt-adapter and dbt-core.
Solution
valid_error_names
on instantiation, for use in validationvalid_error_names
duringWarnErrorOptions
construction in dbt-core withALL_EVENT_NAMES
(combines adapter+common+core events)helper_types
is defined in common and only has dbt-common dependencies!Checklist