Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete dbt/adapters and add dbt-adapters package #9401

Merged
merged 9 commits into from
Jan 23, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Jan 18, 2024

resolves #9430

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@colin-rogers-dbt colin-rogers-dbt changed the title delete dbt/adapters delete dbt/adapters and add dbt-adapters package Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af18862) 86.96% compared to head (0b4aea1) 87.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9401      +/-   ##
==========================================
+ Coverage   86.96%   87.82%   +0.85%     
==========================================
  Files         187      150      -37     
  Lines       25014    21904    -3110     
==========================================
- Hits        21754    19237    -2517     
+ Misses       3260     2667     -593     
Flag Coverage Δ
integration 85.28% <100.00%> (+0.92%) ⬆️
unit 62.36% <100.00%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review January 23, 2024 18:59
@colin-rogers-dbt colin-rogers-dbt requested review from a team as code owners January 23, 2024 18:59
@colin-rogers-dbt colin-rogers-dbt self-assigned this Jan 23, 2024
@@ -72,6 +72,7 @@
"minimal-snowplow-tracker~=0.0.2",
"dbt-semantic-interfaces~=0.5.0a2",
"dbt-common~=0.1.0",
"dbt-adapters~=0.1.0a2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we go!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Remove dbt/adapters in favor of dbt-adapters
2 participants