Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestGenerateCatalogWithExternalNodes #9457

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jan 25, 2024

resolves #9481

Problem

No test for catalog generation for external nodes

Solution

Add TestGenerateCatalogWithExternalNodes

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 25, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk marked this pull request as ready for review January 29, 2024 19:17
@MichelleArk MichelleArk requested a review from a team as a code owner January 29, 2024 19:17
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we not want to port back the include_empty_nodes line?

@MichelleArk
Copy link
Contributor Author

MichelleArk commented Jan 29, 2024

@aranke There's nowhere to port it to because 1.6.latest generate does not use a ResourceTypeSelector: https://github.com/dbt-labs/dbt-core/blob/1.6.latest/core/dbt/task/generate.py

This is not an issue in 1.6.latest, just putting a test in for good measure.

@MichelleArk MichelleArk merged commit cd3c2d2 into 1.6.latest Jan 31, 2024
49 checks passed
@MichelleArk MichelleArk deleted the 1.6/test-external-node-in-catalog branch January 31, 2024 17:55
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants