Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8948: Add target-path to retry #9646

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Fix #8948: Add target-path to retry #9646

merged 5 commits into from
Feb 23, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Feb 23, 2024

resolves #8948

Problem

retry didn't support the target-path flag

Solution

Add the target-path flag to retry as well as tests

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (869ba18) to head (aa02e3f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9646      +/-   ##
==========================================
+ Coverage   88.00%   88.05%   +0.04%     
==========================================
  Files         176      176              
  Lines       22311    22312       +1     
==========================================
+ Hits        19634    19646      +12     
+ Misses       2677     2666      -11     
Flag Coverage Δ
integration 85.71% <100.00%> (+0.11%) ⬆️
unit 62.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review February 23, 2024 16:45
@aranke aranke requested a review from a team as a code owner February 23, 2024 16:45
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a 1 line PR with some tests. Looks good.

@aranke aranke merged commit d1e400e into main Feb 23, 2024
52 checks passed
@aranke aranke deleted the fix_8948 branch February 23, 2024 17:28
Copy link
Contributor

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-9646-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1e400eed20a2f0dc898d6df5ff0efc19298684e
# Push it to GitHub
git push --set-upstream origin backport-9646-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-9646-to-1.7.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3294] [Bug] dbt retry does not respect target-path CLI flag / env variable
2 participants