Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to v1.5.latest] Restrict protobuf < 5 in v1.5.x branch for adapters #9831

Closed
wants to merge 3 commits into from

Conversation

niteshy
Copy link
Contributor

@niteshy niteshy commented Mar 28, 2024

resolves #9830 in v1.5.x branch

Problem

Currently in production, dbt-core v1.5.10 are using protobuf > 5.x versions ie 5.26.0 which is not compatible with dbt-core as mentioned in #9630. Even though the backports are done for it, but not in the setup.py. Which results into adapter installing protobuf > 5

Solution

Restrict the protobuf in setup.py

Checklist

  • [ x] I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

Fixing dbt-labs#9676, as it is missed to restrict to protobuf dependencies in
adapters
@niteshy niteshy requested a review from a team as a code owner March 28, 2024 00:06
@cla-bot cla-bot bot added the cla:yes label Mar 28, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@wiz-inc-266a8a9c32
Copy link

wiz-inc-266a8a9c32 bot commented Mar 28, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 1M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 1M 0L 0I
Secrets 0🔑

@github-actions github-actions bot added the community This PR is from a community member label Mar 28, 2024
@niteshy niteshy changed the title V1.5 adapter fixes [Backport to v1.5.latest] Restrict protobuf < 5 in v1.5.x branch for adapters Mar 28, 2024
@niteshy niteshy changed the base branch from main to backport/1.5.latest-8598-multioption March 28, 2024 00:10
@niteshy niteshy changed the base branch from backport/1.5.latest-8598-multioption to 1.5.latest March 28, 2024 00:11
Copy link

cla-bot bot commented Mar 28, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @niteshy

@dbeatty10
Copy link
Contributor

Thank you for raising this @niteshy !

Since this is covered by #9708 now, I'm going to close this PR.

Thanks again for your help alerting about this issue and identifying the fix 🏆

@dbeatty10 dbeatty10 closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Duplicate dependency specifications means prod and dev version of protobuf might differ
2 participants