-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unwanted dev dependency #9838
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9838 +/- ##
==========================================
- Coverage 88.12% 88.12% -0.01%
==========================================
Files 178 178
Lines 22458 22449 -9
==========================================
- Hits 19792 19783 -9
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution 🙂 This will 100% reduce accidental dev/released version discrepancies that we want to avoid. One small nit in the change log to make things a bit clearer, but then we're good to go 👍
@@ -0,0 +1,6 @@ | |||
kind: Dependencies | |||
body: Remove unwanted dependency of protobuf in dev-requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit:
Can we replace the word unwanted
with duplicate
here. The word unwanted
without the context that this dependency is getting pulled in somewhere else makes it sound like we're dropping the dependency completely.
Gonna get this merged! Of note, we don't need to backport this. We try to only do backports for bugs and security issues. The risk we incur by not backporting this in exceedingly low. The risk is that in the future we backport a change to the version specification of protobuf (which we've only ever had to do once) and only only update the dep in |
resolves #9830
Avoid causing problem similar to #9830
Problem
protobuf is listed as dependencies in both setup.py & dev-requirements.txt. It cause problem as shown in #9830
Solution
Remove the duplicate entry from dev-requirements, as it is used in the prod code already.
Checklist