Merge pull request #48 from fishtown-analytics/fix/dag-dropup-selects

(#47) fix for broken tag and package selectors
dbt-labs · Sep 4, 2019 · fca8262 · fca8262
2 parents e2f779b + 49dfa90
commit fca8262
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/Gemfile b/Gemfile
@@ -1,5 +1,5 @@
 # Hint for netlify to install jekyll for the styleguide submodule
 source "https://rubygems.org"
 
-gem "jekyll"
+gem "jekyll", '~>3.8'
 
diff --git a/src/app/components/graph/graph-launcher.html b/src/app/components/graph/graph-launcher.html
@@ -100,7 +100,9 @@ <h6>
                                   ng-class="{visible: filters_visible}"
                                   ng-submit="onUpdateSelector()">
                                 <label class="field">
-                                    <div class="dropup" data-form-type="packages">
+                                    <div class="dropdown dropup"
+                                         ng-class="{'open': isVisible('packages')}"
+                                         data-form-type="packages">
                                         <select
                                             data-toggle="dropdown"
                                             class='field-input form-control input-dark'
@@ -112,8 +114,7 @@ <h6>
                                         </select>
                                         <ul
                                             class="dropdown-menu"
-                                            ng-show="isVisible('packages')"
-                                            style="display: block">
+                                            ng-show="isVisible('packages')">
                                             <li
                                                 class='text-dark'
                                                 ng-repeat="item in selectorService.options.packages"
@@ -128,7 +129,9 @@ <h6>
                                     </div>
                                 </label>
                                 <label class="field">
-                                    <div class="dropup" data-form-type="tags">
+                                    <div class="dropdown dropup"
+                                         ng-class="{'open': isVisible('tags')}"
+                                         data-form-type="tags">
                                         <select
                                             data-toggle="dropdown"
                                             class='field-input form-control input-dark'
@@ -140,8 +143,7 @@ <h6>
                                         </select>
                                         <ul
                                             class="dropdown-menu"
-                                            ng-show="isVisible('tags')"
-                                            style="display: block">
+                                            ng-show="isVisible('tags')">
                                             <li
                                                 class='text-dark'
                                                 ng-repeat="item in selectorService.options.tags"