-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added search by columns. #23
Conversation
@rmgpinto this is amazing!! Thanks for opening this PR! I think you're the first external contributor to the docs website :) I'd love to get this merged - let me play around with this today and get back to you early next week! |
@drewbanin all done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmgpinto this is really great!
My one bit of UX feedback is that the columns:
list should be contained within the clickable search result div. In playing around with this, it looks like the Show X more
link might be hard to click when the user hovers over a particular search result. Was that your thinking here?
Otherwise, the code looks really wonderful and I'm super impressed with this PR! Let me know what you think about the "columns:" div placement :)
Thanks for the suggestion @drewbanin, I've reflected that on the layout and it looks better now :) I had to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmgpinto it was a true pleasure to receive and review this PR -- thanks for your contribution to dbt Docs! I'm going to merge this, and we're going to slip it into the 0.13.1 release of dbt, to be released later this week :)
Thanks, and great work!
Thanks @drewbanin! |
@drewbanin I've added the ability to search by columns.
Changes:
project_service.js
: refactoredfuzzySearchObj
function to allow search bystring
orobject
(json tree). On a later PR I can add search byarray
which will allow to search for model tags as well.search.html
: changed html to reflect layout shown in screenshot (see below). The layout has a Show More... to expand the results of more than 3 columns, just like at the end of the model search results.search.js
: addedcolumnFilter
andlimitColumns
functions to execute the search logic.Screenshot: link