Add support for Trino

[damian3031]

This is a:

• bug fix PR with no breaking changes
• new functionality

Link to Issue

Closes #375

Checklist

• I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
  • BigQuery
  • Postgres
  • Redshift
  • Snowflake
  • Databricks
  • DuckDB
  • Trino
• I have updated the README.md (if applicable)
• I have added tests & descriptions to my models (and macros if applicable)

[damian3031]

I've added integration tests to CircleCI. Please add below environment variables relevant for your Starburst Galaxy instance (AFAIK you have one) so that the tests can run on it.
TRINO_TEST_HOST, TRINO_TEST_USER, TRINO_TEST_PASS, TRINO_TEST_PORT, TRINO_TEST_CATALOG_NAME

[b-per]

Thanks @damian3031 !
I am testing it locally right now and we will add the Starburst credentials for CI/CD!

Based on my initial testing (using a Snowflake catalog) there are some issues (which might required updates to dbt-trino):

• if a table has a description, it is added to the DDL but I then get the error TrinoUserError(type=USER_ERROR, name=NOT_SUPPORTED, message="This connector does not support creating tables with table comment", query_id=abcd)
  • is it possible to disable the comment part of the DDL? it doesn't seem to be based on the code I saw in dbt-trino
• I am also getting some errors This connector does not support creating views which seems consistent with this issue.

Based on the observations above:

• what catalog type would you recommend to avoid those errors? (or which one did you test with for now)
• should we test the package for different catalog types?
• we might need to add some info in the README to mention that some catalog types will work with Trino but not all

[damian3031]

@b-per creating views is supported in object storage connectors such as Hive, Delta Lake, and Apache Iceberg.

I tested it on the Iceberg connector, and the tests passed.

I think it would be fair to test it specifically against Iceberg connector and mention it in the README.

[b-per]

Thanks for the work here!

All good with me with the small exception of updating the CI config file to run Trino at the same time as Snowflake/BQ etc...

I have added the env vars to test on S3 and it works

[b-per]

We'll do a new release of the package on the dbt Hub in just a beat so that it is accessible to users.
EDIT: this should read "bit" and not "beat", but "beat" kinda sounds good as well!

[andrea-montes-yello]

We'll do a new release of the package on the dbt Hub in just a beat so that it is accessible to users.

Yeiii, thank you!!