Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pre-commit only #777

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Move to pre-commit only #777

merged 5 commits into from
Apr 22, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

dbt-redshift starting taking a long time to build (sometimes 10-20 minutes). It turns out that we had some type of dependency version interaction.

Solution

I moved linting dependencies into .pre-commit-config.yaml and things cleared up. It builds in under a minute now. This also aligns with the direction we're taking elsewhere (e.g. dbt-postgres).

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 19, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 19, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Apr 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@cla-bot cla-bot bot added the cla:yes label Apr 19, 2024
@mikealfare mikealfare requested a review from a team April 19, 2024 21:56
@mikealfare mikealfare merged commit eb0c74b into main Apr 22, 2024
35 checks passed
@mikealfare mikealfare deleted the move-to-precommit-only branch April 22, 2024 17:14
mikealfare added a commit that referenced this pull request Jul 17, 2024
* moving linting config into pre-commit-config
* remove explicit call to mypy
* run linting
* fix enum reference
mikealfare added a commit that referenced this pull request Jul 17, 2024
* moving linting config into pre-commit-config
* remove explicit call to mypy
* run linting
* fix enum reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants