Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing test TestColumnQuotingDefault on unsupported versions #858

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

The test tests/integration/column_quoting/test_column_quotes.py::TestColumnQuotingDefault::test_redshift_column_quotes is consistently failing. While this version is no longer supported, this would block merging anything, such as a security vulnerability patch.

Solution

Skip the test.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jul 17, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 17, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jul 17, 2024
@mikealfare mikealfare merged commit f4344f1 into 1.4.latest Jul 17, 2024
30 checks passed
@mikealfare mikealfare deleted the backport/1.4.latest/skip-column-quote-test branch July 17, 2024 20:09
github-actions bot pushed a commit that referenced this pull request Jul 17, 2024
…858)

* skip failing test on unsupported version

(cherry picked from commit f4344f1)
github-actions bot pushed a commit that referenced this pull request Jul 17, 2024
…858)

* skip failing test on unsupported version

(cherry picked from commit f4344f1)
github-actions bot pushed a commit that referenced this pull request Jul 17, 2024
…858)

* skip failing test on unsupported version

(cherry picked from commit f4344f1)
github-actions bot pushed a commit that referenced this pull request Jul 17, 2024
…858)

* skip failing test on unsupported version

(cherry picked from commit f4344f1)
mikealfare added a commit that referenced this pull request Jul 17, 2024
…858) (#864)

* skip failing test on unsupported version

(cherry picked from commit f4344f1)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Jul 17, 2024
…858) (#863)

* skip failing test on unsupported version

(cherry picked from commit f4344f1)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Jul 17, 2024
…858) (#862)

* skip failing test on unsupported version

(cherry picked from commit f4344f1)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Jul 17, 2024
…858) (#861)

* skip failing test on unsupported version

(cherry picked from commit f4344f1)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants