Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation #1108

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jul 9, 2024

resolves #dbt-labs/dbt-adapters#250
docs dbt-labs/docs.getdbt.com/#

Problem

user raised issue around "While working with DBT incremental config: on_schema_change='append_new_columns'
The append new columns flag is not able to capture the correct case-sensitive column name and add it to the incremental table causing the run to fail."

they stated they were using snowflake.

Solution

add a new test to dbt-adapters-tests to check that column quoting case sensitivity is expressed correctly, update all macros in adapters as needed if they do not use the default implementation and test default implementing macros to see if we need to update the dbt-adapters macro as well.

Todo:

  • test with rest of adapters (see if dbt-adapter default version of macro needs to be changed or any other adapter override version of macro).
  • make sure new tests works in all adapters as needed
  • update requirements files either dev-requirements or project.toml files before merger

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Jul 9, 2024
@McKnight-42 McKnight-42 requested a review from a team as a code owner July 9, 2024 19:31
@cla-bot cla-bot bot added the cla:yes label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 marked this pull request as draft July 9, 2024 19:36
@McKnight-42
Copy link
Contributor Author

snippets from a test runs logs:

create or replace transient table DBT_TEST.test17205532125894120837_test_incremental_on_schema_change.src_artists
         as
        (



    select convert_timezone('UTC', current_timestamp()) as inserted_at, 'john' as name


        );
|          INSERTED_AT | NAME |
| -------------------- | ---- |
| 2024-07-09 19:26:... | john |
create or replace transient table DBT_TEST.test17205532125894120837_test_incremental_on_schema_change.src_artists
         as
        (



    -- add a non-zero version to the end of the command to get a different version:
    -- --vars "{'version': 1}"
    select convert_timezone('UTC', current_timestamp()) as inserted_at, 'john' as Name, 'engineer' as "Job"


        );
|          INSERTED_AT | NAME | Job      |
| -------------------- | ---- | -------- |
| 2024-07-09 19:26:... | john |          |
| 2024-07-09 19:27:... | john | engineer |

@McKnight-42 McKnight-42 changed the title Snowflake alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation [CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation Aug 5, 2024
@McKnight-42 McKnight-42 removed their assignment Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant