Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1458] [Feature] change default dbt-py method to anonymous stored procedures #334

Merged
merged 3 commits into from
Dec 2, 2022
Merged

[CT-1458] [Feature] change default dbt-py method to anonymous stored procedures #334

merged 3 commits into from
Dec 2, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Nov 30, 2022 •
edited
Loading

resolves #305

Description

changing default of use_anonymous_sproc in snowflake to True for default for python models

Checklist

@McKnight-42 McKnight-42 self-assigned this Nov 30, 2022
@cla-bot cla-bot bot added the cla:yes label Nov 30, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 requested a review from Fleid November 30, 2022 17:49
ChenyuLInx
ChenyuLInx approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChenyuLInx ChenyuLInx merged commit e68dcf3 into main Dec 2, 2022
@ChenyuLInx ChenyuLInx deleted the mcknight/ct-1458 branch December 2, 2022 02:31
@ChenyuLInx
Copy link
Contributor

@McKnight-42 Sorry I clicked the merge by accident. If you need other update you can just open a new PR

@jtcohen6 jtcohen6 mentioned this pull request Dec 7, 2022
Closed
1 task
@jtcohen6 jtcohen6 mentioned this pull request Apr 10, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@Fleid Fleid Awaiting requested review from Fleid

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1458] [Feature] change default dbt-py method to anonymous stored procedures (sprocs)
2 participants
@McKnight-42 @ChenyuLInx