Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust tox passenv to be multiline #345

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Adjust tox passenv to be multiline #345

merged 2 commits into from
Dec 8, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Dec 8, 2022 •
edited
Loading

dbt-labs/dbt-core#6405 provides a fair amount of context

Description

In tox 4, space-separated variables specified for passenv are not passed into the container.

[testenv:inline]
passenv = FOO BAR
☝️ doesn't work on tox 4

[testenv:separate-lines]
passenv =
    FOO
    BAR
  • will need backport to at least 1.1.latest

Checklist

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Dec 8, 2022
@McKnight-42 McKnight-42 self-assigned this Dec 8, 2022
@cla-bot cla-bot bot added the cla:yes label Dec 8, 2022
jtcohen6
jtcohen6 reviewed Dec 8, 2022
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@McKnight-42 McKnight-42 requested a review from jtcohen6 December 8, 2022 17:25
VersusFacit
VersusFacit approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@McKnight-42 McKnight-42 merged commit 65e0a80 into main Dec 8, 2022
@McKnight-42 McKnight-42 deleted the mcknight/tox-passenv branch December 8, 2022 21:42
github-actions bot pushed a commit that referenced this pull request Dec 8, 2022
@McKnight-42 @github-actions
Adjust tox passenv to be multiline (#345)
4dc76c5 
* passenv spacing changes post tox release of 4.0

* formatting

(cherry picked from commit 65e0a80)
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Dec 8, 2022
@McKnight-42 @github-actions
Adjust tox passenv to be multiline (#345)
f9713dd 
* passenv spacing changes post tox release of 4.0

* formatting

(cherry picked from commit 65e0a80)
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Dec 8, 2022
@McKnight-42 @github-actions
Adjust tox passenv to be multiline (#345)
ee20eae 
* passenv spacing changes post tox release of 4.0

* formatting

(cherry picked from commit 65e0a80)
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Merged
McKnight-42 added a commit that referenced this pull request Dec 8, 2022
@github-actions @McKnight-42
Adjust tox passenv to be multiline (#345) (#346)
9387513 
* passenv spacing changes post tox release of 4.0

* formatting

(cherry picked from commit 65e0a80)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
McKnight-42 added a commit that referenced this pull request Dec 8, 2022
@github-actions @McKnight-42
Adjust tox passenv to be multiline (#345) (#348)
84fe635 
* passenv spacing changes post tox release of 4.0

* formatting

(cherry picked from commit 65e0a80)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
McKnight-42 added a commit that referenced this pull request Dec 8, 2022
@github-actions @McKnight-42
Adjust tox passenv to be multiline (#345) (#347)
56286b6 
* passenv spacing changes post tox release of 4.0

* formatting

(cherry picked from commit 65e0a80)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
alexander-smolyakov pushed a commit to dbt-labs/dbt-snowflake-release-test that referenced this pull request Dec 13, 2022
@McKnight-42 @alexander-smolyakov
Adjust tox passenv to be multiline (dbt-labs#345)
639f091 
* passenv spacing changes post tox release of 4.0

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

@mikealfare mikealfare Awaiting requested review from mikealfare

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McKnight-42 @jtcohen6 @VersusFacit