Revert #367 #378
Merged
Revert #367 #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
commented
Jun 29, 2022
| - Initialize lift + shift for cross-db macros ([#359](https://github.com/dbt-labs/dbt-spark/pull/359)) | ||
| - Add invocation env to user agent string ([#367](https://github.com/dbt-labs/dbt-spark/pull/367)) | ||
| - Use dispatch pattern for get_columns_in_relation_raw macro ([#365](https://github.com/dbt-labs/dbt-spark/pull/365)) | ||
|
|
||
| ### Contributors | ||
| - [@ueshin](https://github.com/dbt-labs/dbt-spark/commits?author=ueshin) ([#365](https://github.com/dbt-labs/dbt-spark/pull/365)) | ||
| - [@ueshin](https://github.com/ueshin) ([#365](https://github.com/dbt-labs/dbt-spark/pull/365)) |
There was a problem hiding this comment.
I just happened to notice this while resolving changelog conflicts. Unrelated to the substantive changes being reverted in this PR.
|
The failing test will be resolved in a separate PR: #375 |
dbeatty10
approved these changes
Jun 29, 2022
ueshin
added a commit
to databricks/dbt-databricks
that referenced
this pull request
Jul 5, 2022
ueshin
added a commit
to databricks/dbt-databricks
that referenced
this pull request
Jul 5, 2022
francescomucio
pushed a commit
to francescomucio/dbt-spark
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#367 added an environment variable to server-side user-agent tracking. This was a mistake, for two reasons: