Remove deprecated table argument from unpivot()

[joellabes]

Describe the feature

We swapped from table to relation in a long-past version of dbt utils, and promised it would be deprecated one day.

dbt-utils/macros/sql/unpivot.sql

Lines 21 to 28 in fc8b083

	{% if table %}
	{%- set error_message = '
	Warning: the `unpivot` macro no longer accepts a `table` parameter. \
	This parameter will be deprecated in a future release of dbt-utils. Use the `relation` parameter instead. \
	The {}.{} model triggered this warning. \
	'.format(model.package_name, model.name) -%}
	{%- do exceptions.warn(error_message) -%}
	{% endif %}

That day has come.

This looks like:

• Removing the table parameter
• Removing the checking for table, as well as checking for both table and relation.
• Remove the test_unpivot_original_api test
• The remaining tests should continue to pass

Who will this benefit?

Future users of this macro, who won't have conflicting and confusing documentation. Lovers of clean code

Are you interested in contributing this feature?

Leaving it for a community member who wants to get into OSS contributions!

[ethanotran]

Can I work on this one? Looking for my first open source contribution.

[joellabes]

Can I work on this one? Looking for my first open source contribution.

@ethanotran it looks like Miles might have already done some work on this one I'm sorry! I'm on mobile so I can't see exactly, or whether there's any others from the crop I opened earlier this week that are unclaimed. If you do find one, feel free to assign it to yourself 👍