Schema test/not accepted values #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clrcrl
force-pushed
the
schema_test/not_accepted_values
branch
from
d198c6b to
f60eebc
Compare
|
Just did a small rebase on your branch so that we don't have merge conflicts! This is really great — I'm still thinking a little about the name here: is "not accepted" best, or is something like disallowed, or barred, better? |
|
When I was looking for this functionality I was mainly searching for "not accepted values", but disallowed or rejected for example could be fine too! I would say that barred seems less familiar to me, but up to you! |
|
The more I sat with it, the more I thought "not allowed" felt very descriptive, let's merge! |
clrcrl
approved these changes
Dec 23, 2020
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
Schema Test - Not accepted values, test fixed empty lines at the end Update changelog
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
Schema Test - Not accepted values, test fixed empty lines at the end Update changelog
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
Schema Test - Not accepted values, test fixed empty lines at the end Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
main)Description & motivation
This is a new macro that will allow us to check
not accepted values, exactly the opposite ofaccepted_values.I'm already using it in a table with users and roles where I want to ensure that some roles are not inside that table.
This will close #283
Checklist
I have a doubt about testing this kind of macros, writing a test that uses the macro only tests when it works, but not when it fails. Is there any way of testing when it fails?
Also, this is my first PR, I hope I did everything ok 🙂