Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: insert by period for 0.19 #320

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jan 6, 2021

Extends #319, fixup of #309 (v0.6.3)

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

  • Update insert_by_period in a way that should be compatible for v0.19.0 and earlier versions. I'm hoping we can release this as a patch to 0.6.3, rather than a new minor version :) I tested on v0.19.0-rc1 and v0.18.1.
  • Include a --full-refresh step to build test_insert_by_period twice

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@jtcohen6 jtcohen6 requested a review from clrcrl January 6, 2021 18:53
@clrcrl clrcrl merged commit 46dbfed into 0-19-0-updates Jan 6, 2021
@joellabes joellabes deleted the fix/insert-by-period-0-19 branch October 21, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants