fix usage and quoting to fix hub #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coapacetic
commented
Feb 17, 2021
Comment on lines
515
to
518
| > This macro will soon be deprecated in favor of the more flexible `get_relations_by_pattern` macro (above) | ||
|
|
||
| Returns a list of [Relations](https://docs.getdbt.com/docs/writing-code-in-dbt/class-reference/#relation) | ||
| that match a given prefix, with an optional exclusion pattern. It's particularly |
There was a problem hiding this comment.
I think this little bit of whitespace should do the trick 😄
|
(closing out all things that might be open on my list) feel free to merge, not merge, close / whatever seems appropriate here 😄 |
|
Changing the base to |
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
clrcrl
pushed a commit
that referenced
this pull request
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
masterdev/branchdev/branchDescription & motivation
hub.getdbt.com isn't looking so great. I think the culprit is the use of a
>for quoting in markdown. I'm submitting this PR to hopefully then see this fixed over at hub.getdbt.com. While I was here, I also ensured that allusageheadings were bolder for easier reading.Here is an screenshot of hub.getdbt.com that isn't looking so hot right now.
Checklist