Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow star macro to be case insensitive. Improve docs while we're here. #348

Merged
merged 5 commits into from
Mar 30, 2021

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Mar 30, 2021

This is a:

  • new functionality — please ensure the base branch is the latest dev/ branch
  • a quality of life change

Description & motivation

This picks up work from #281 (via @mdimercurio) and polishes it off given the more recent changes to this macro. While here, I also improved the docs a little.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@clrcrl clrcrl mentioned this pull request Mar 30, 2021
11 tasks
@clrcrl clrcrl merged commit b3a7b0e into dev/0.7.0 Mar 30, 2021
@joellabes joellabes deleted the lowercase-star branch October 21, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant