Fix regression with cardinality equality when field names are different #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a bug introduced in #310
This is a:
master
dev/
branchdev/
branchDescription & motivation
I started getting a cardinality equality test failure after upgrading from 0.6.2 to 0.6.4 (as part of upgrading dbt from 0.18.1 to 0.19.1). Turns out that the SQL wasn't being written properly when the column being tested and the reference didn't use the same name.
Checklist
NOTE: I would love to have written tests for this but struggled getting started. There didn't seem to be an existing test for this macro, so I didn't have much to go on. Also, when I ran
make test target=postgres
according to these instructions, I got the errorCould not render {{ env_var('POSTGRES_TEST_HOST') }}: Env var required but not provided: 'POSTGRES_TEST_HOST'
. It wasn't clear to me how to resolve this without much deeper work, so I gave up.